Attention is currently required from: Lean Sheng Tan. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47388 )
Change subject: soc/intel/elkhartlake: Adding PSE TSN support & PSE UPDs configs ......................................................................
Patch Set 5:
(5 comments)
File src/soc/intel/elkhartlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47388/comment/3e05f32b_74844fa9 PS5, Line 66: tsnmac.bin Since you use this filename in the code to access it, would it make sense to have a common define for it? Maybe even a Kconfig entry?
https://review.coreboot.org/c/coreboot/+/47388/comment/058b539c_1d909c6c PS5, Line 71: tsnconfig.bin Same here.
https://review.coreboot.org/c/coreboot/+/47388/comment/774feaf1_28e3149e PS5, Line 76: psetsnipconfig.bin And here.
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47388/comment/345ca16a_a8155714 PS5, Line 30: /** PCH PSE ownership assignments Woukd it make sense to drop the PSE_CONFIG_ prefix as this is already defined by the enum type?
https://review.coreboot.org/c/coreboot/+/47388/comment/c7c89351_bf5b7d26 PS5, Line 47: TSN_PHY_SGMII = 0x2, Same question here.