Attention is currently required from: Lean Sheng Tan.
5 comments:
File src/soc/intel/elkhartlake/Makefile.inc:
Patch Set #5, Line 66: tsnmac.bin
Since you use this filename in the code to access it, would it make sense to have a common define for it? Maybe even a Kconfig entry?
Patch Set #5, Line 71: tsnconfig.bin
Same here.
Patch Set #5, Line 76: psetsnipconfig.bin
And here.
File src/soc/intel/elkhartlake/fsp_params.c:
Patch Set #5, Line 30: /** PCH PSE ownership assignments
Woukd it make sense to drop the PSE_CONFIG_ prefix as this is already defined by the enum type?
Patch Set #5, Line 47: TSN_PHY_SGMII = 0x2,
Same question here.
To view, visit change 47388. To unsubscribe, or for help writing mail filters, visit settings.