22 Mar
2019
22 Mar
'19
12:33 a.m.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 4:
(1 comment)
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
This signal is pen inserted. […]
It only has a switch on proto to test now. When you press the switch, the value of evtest is 0. When you release the switch, the value of evtest is 1.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be
Gerrit-Change-Number: 31815
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Evan Green evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-CC: John Su john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 22 Mar 2019 07:33:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment