Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation ......................................................................
Patch Set 7:
Patch Set 7:
(1 comment)
By the way, I'm not sure how much of a service you're doing by indicating "will do" or "will rewrite". Did you see that notice about All-Comments-Resolved? Because of that new requirement, you will still need to go back and mark each of those Done, Ack, or manually Resolve in a new comment. It would seem more efficient (especially to your reviewers) to negotiate items you disagree on, as you did above, and leave the others until you repush. At that time, you'd just mark those as Done.
I could do that if I was executing the changes immediately... as I'm involved in something else (SPI code) I have to answer the review so that reviewers no I saw it, but have to make it obvious to my self that I have not yet implemented something (locally, not yet pushed).