Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45845 )
Change subject: soc/intel/xeon_sp/cpx: Add soc_acpi_fill_fadt()
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45845/8/src/soc/intel/xeon_sp/cpx/a...
File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/45845/8/src/soc/intel/xeon_sp/cpx/a...
PS8, Line 161: ACPI_FADT_SEALED_CASE
I don't think we want to set this
This is set to match intel/commom/block/acpi/acpi.c. Use soc_acpi_fill_fadt()
to set cpx fadt->flags for the platform. We are getting close to removing this file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c04dd478aa5e0f1467e63d06da094128edd9650
Gerrit-Change-Number: 45845
Gerrit-PatchSet: 8
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Oct 2020 18:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment