Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31635 )
Change subject: soc/intel/skylake: nhlt: Add 24 bit blobs for Max98373
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31635/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31635/3//COMMIT_MSG@17
PS3, Line 17: 24-bit
Above you use no minus. As the minus is also used in the code, I’d update all occurrences in the commit message to use a minus too.
https://review.coreboot.org/#/c/31635/3//COMMIT_MSG@19
PS3, Line 19: is
are
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62cc109fb0aca9269736779a6ce80980b0571b78
Gerrit-Change-Number: 31635
Gerrit-PatchSet: 4
Gerrit-Owner: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jenny Tc
jenny.tc@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 03 Apr 2019 11:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment