[coreboot-gerrit] [L] Change in coreboot[main]: cpu/x86/smm: Move smmstore entry to a common place

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Jeff Daly, Matt DeVillier, Vanessa Eusebio.

Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83067?usp=email )

Change subject: cpu/x86/smm: Move smmstore entry to a common place
......................................................................

Patch Set 8: Code-Review+1

(1 comment)

File src/soc/intel/common/block/smm/smihandler.c:

https://review.coreboot.org/c/coreboot/+/83067/comment/9f1e437f_128c090e?usp... :
PS8, Line 275: 	const bool wp_enabled = !fast_spi_wpd_status();
             : 	if (wp_enabled) {
             : 		set_insmm_sts(true);
             : 		/*
             : 		 * As per BWG, clearing "SPI_BIOS_CONTROL_SYNC_SS"
             : 		 * bit is a must prior setting SPI_BIOS_CONTROL_WPD" bit
             : 		 * to avoid 3-strike error.
             : 		 */
             : 		fast_spi_clear_sync_smi_status();
             : 		fast_spi_disable_wp();
             : 	}
Somebody might miss this?