Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34797 )
Change subject: soc/intel/common/smm: Remove redundant masking op
......................................................................
Patch Set 5:
(1 comment)
That whole
https://review.coreboot.org/c/coreboot/+/34797/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/smm/smitraphandler.c:
https://review.coreboot.org/c/coreboot/+/34797/5/src/soc/intel/common/block/...
PS5, Line 109:
:
I agree with the earlier top level conversation.
since this is in the monitor code, it seems like we're just missing a printk here and the mask of the data should be left in place.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34797
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71da74e5e08e7d7e6d61c1925db19324efd73f0a
Gerrit-Change-Number: 34797
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Comment-Date: Fri, 09 Aug 2019 19:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment