Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42548 )
Change subject: Add qc_blobs repository
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42548/3/.gitmodules
File .gitmodules:
https://review.coreboot.org/c/coreboot/+/42548/3/.gitmodules@52
PS3, Line 52: update = none
I assume you mean `git submodule update --checkout`? If I understand it correctly, the `--checkout` […]
Yes, `git submodule update --checkout`. It's also an alias in our gitconfig
AFAIR.
I don't think what is controversial is a binary decision. We started to use
`update = none` for any non-source repository. I wouldn't mind if we change
that, but others might. And I would have no idea where to put `amd_blobs`.
It also has a needs-to-be-read-first license, but compared to the `qc_blobs`
license, it looks like day and night.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42548
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I247746c1b633343064c9f32ef1556000475d6c4a
Gerrit-Change-Number: 42548
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Assignee: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Sun, 27 Dec 2020 16:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment