Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30559 )
Change subject: drivers/spi: Add controller protection type
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30559/6/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/#/c/30559/6/src/southbridge/intel/common/spi.c@2...
PS6, Line 299: if (IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_IBEXPEAK) ||
: IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_BD82X6X) ||
: IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_C216) ||
: IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801GX))
this is wrong. it's just INTEL_I82801GX that doesn't support it.
indeed, wrong. Fixed now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I093884c4768b08a378f21242ac82e430ac013d15
Gerrit-Change-Number: 30559
Gerrit-PatchSet: 7
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 15:21:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment