Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28380 )
Change subject: [WIP] Nvidia Optimus support for ThinkPads ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layou... File src/mainboard/lenovo/t430/cmos.layout:
https://review.coreboot.org/#/c/28380/2/src/mainboard/lenovo/t430/cmos.layou... PS2, Line 131: Graphics
Unrelated to optimus as you can use two GPUs even without it. Please add it in a separate commit.
Do you think I should move has_thinker1 changes in devicetrees to a separate commit too?
By the way I'm not sure "has_thinker1" is correct, as they seemingly don't have thinker1 (according to schematics), but dGPU registers still work and it seems it's the only usage of has_thinker1 in coreboot.