Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32903 )
Change subject: soc/intel/apollolake: Fix issue found by Clang Static Analyzer
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32903/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32903/2//COMMIT_MSG@7
PS2, Line 7: soc/intel/apollolake: Fix issue found by Clang Static Analyzer
Please describe the issue here. It’s not useful in the commit message *summary* to know that it was found by a certain tool. This should be mentioned in the commit message body.
So please rephrase. Maybe (no idea if it’s correct):
Remove redundant ACPI GNVS addition to CBMEM
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9421af4a556d1d88183aa938ee2a124a10ab727
Gerrit-Change-Number: 32903
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 May 2019 08:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment