Attention is currently required from: Eric Lai, Haribalaraman Ramasubramanian, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, V Sowmya.
Ronak Kanabar has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/78932?usp=email )
Change subject: mb/google/brya: Add romstage early graphics for nissa
......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78932/comment/f753bc24_64917d02?usp... :
PS5, Line 9: 1) Add all changes needed for early graphics
What panel is used for the calculations in devicetree?
I am checking if I can disclose the panel number here
File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/78932/comment/a6bdd197_848ced62?usp... :
PS7, Line 178: #+-----------------------------+---------------------------------------+-----+
currently i915_gpu_panel_config we dose not have member to override T8. […]
I think we should merge this at least be on par with what brya has and then add option for T8 and do change for all platforms? let me know if that is okay.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78932?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33cfc5d1f8c25c344e598befd21c50a78a65275a
Gerrit-Change-Number: 78932
Gerrit-PatchSet: 7
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 23 May 2024 06:08:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com