Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43760 )
Change subject: mb/clevo/kbl-u: Add Clevo N240BU as variant ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43760/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43760/16//COMMIT_MSG@6 PS16, Line 6: : mb/clevo/kbl-u: Add Clevo N240BU as variant : : This is the board used in the Tuxedo BU1406. The ID of the graphics device : differs. so, we should make the BU1406 an OEM variant - Felix and me are looking into Kconfig in the next days to find the best way for this.
Further, I realized N2xxXU all use the same board. These are the differences: - N25XBU has an additional SATA breakout board - N2xxWU have a KBL-R soc
-> we can support them all with the N240BU baseboard
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 54: default 8 if BOARD_CLEVO_N13xWU || BOARD_CLEVO_N240BU
Can’t we always default to 8?
should be ok, yes
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 191: register "serirq_mode" = "SERIRQ_CONTINUOUS"
After removing that, keyboard and mouse didn’t work anymore in Debian GNU/Linux.
damn, I checked the wrong schematics. sry for confusion. SERIRQ is used by EC and TPM. When keyboard stops working, I assume this specific ec does not support quiet mode. I couldn't find info on SERIRQ for SLB9665TT TPM.
Long story short: let's leave that as-is