Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: Load calibration params and run DRAM calibration flow ......................................................................
Patch Set 35:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35110/19//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35110/19//COMMIT_MSG@12 PS19, Line 12: DRAM blob and perform DRAM full calibration.
How much time is saved? Please add specific measurements.
Bootup time added.
https://review.coreboot.org/c/coreboot/+/35110/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35110/30//COMMIT_MSG@14 PS30, Line 14: BUG=b:134351649
Add b:139099592
Done
https://review.coreboot.org/c/coreboot/+/35110/22/src/mainboard/google/kukui... File src/mainboard/google/kukui/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/35110/22/src/mainboard/google/kukui... PS22, Line 30: RW_DDR_TRAINING(PRESERVE) @0x400000 0x2000
This is exceeding the aligned boundary. […]
FMAP layout extended to 8MB in https://review.coreboot.org/c/coreboot/+/35612
https://review.coreboot.org/c/coreboot/+/35110/30/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/30/src/mainboard/google/kukui... PS30, Line 44: CALIBRATION_REGION
Please add an assert for this. […]
Why not assert(length <= 0x2000);
https://review.coreboot.org/c/coreboot/+/35110/32/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/32/src/mainboard/google/kukui... PS32, Line 33: void
Change the type to 'struct params_data' in case the caller passes the wrong type.
Done
https://review.coreboot.org/c/coreboot/+/35110/32/src/mainboard/google/kukui... PS32, Line 42: void
Change the type to 'struct params_data' in case the caller passes the wrong type.
Done