6 comments:
Patch Set #19, Line 12: DRAM blob and perform DRAM full calibration.
How much time is saved? Please add specific measurements.
Bootup time added.
Patch Set #30, Line 14: BUG=b:134351649
Add b:139099592
Done
File src/mainboard/google/kukui/chromeos.fmd:
Patch Set #22, Line 30: RW_DDR_TRAINING(PRESERVE) @0x400000 0x2000
This is exceeding the aligned boundary. […]
FMAP layout extended to 8MB in https://review.coreboot.org/c/coreboot/+/35612
File src/mainboard/google/kukui/romstage.c:
Patch Set #30, Line 44: CALIBRATION_REGION
Please add an assert for this. […]
Why not
assert(length <= 0x2000);
File src/mainboard/google/kukui/romstage.c:
Change the type to 'struct params_data' in case the caller passes the wrong type.
Done
Change the type to 'struct params_data' in case the caller passes the wrong type.
Done
To view, visit change 35110. To unsubscribe, or for help writing mail filters, visit settings.