[coreboot-gerrit] Change in coreboot[master]: mb/amd/mandolin: Add Picasso CRB

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33772 )

Change subject: mb/amd/mandolin: Add Picasso CRB
......................................................................

Patch Set 47:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33772/47/src/mainboard/amd/mandolin... 
File src/mainboard/amd/mandolin/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/33772/47/src/mainboard/amd/mandolin... 
PS47, Line 13: 	0x0017ff00, 0x0017ff00, 0x0017ff00, 0x0017ff00, // Widget node 0x01 :
> Would be nice to use macros for this, but it's easier if done later (easier to check reproducibility […]

yep; it's on the list of things i want to look into