Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37546 )
Change subject: New PCI ID for FCH SATA Controller (AHCI Mode) ......................................................................
Patch Set 1:
(3 comments)
Welcome to coreboot!
https://review.coreboot.org/c/coreboot/+/37546/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37546/1//COMMIT_MSG@7 PS1, Line 7: New PCI ID for FCH SATA Controller (AHCI Mode) Please look through `git log --oneline` on how to format and write git commit message summaries in coreboot.
amd/hudson: Add PCI ID for FCH SATA controller (AHCI Mode)
https://review.coreboot.org/c/coreboot/+/37546/1//COMMIT_MSG@9 PS1, Line 9: The 1022:7904 FCH SATA Controller is found in the AMD Bettong board. Very strange, that there is another ID. Did the chipset revision(?) change somehow on these boards?
https://review.coreboot.org/c/coreboot/+/37546/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37546/1/src/include/device/pci_ids.... PS1, Line 451: #define PCI_DEVICE_ID_AMD_CZ_SATA_AHCI_AMD 0x7904 What is the PCI ID of the non-AHCI mode device?