Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/#/c/33234/7/src/security/intel/stm/Kconfig File src/security/intel/stm/Kconfig:
https://review.coreboot.org/#/c/33234/7/src/security/intel/stm/Kconfig@19 PS7, Line 19: observation and interference. Examples of usage include kernel
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/7/src/security/intel/stm/Kconfig@21 PS7, Line 21:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/7/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/7/src/security/intel/stm/SmmStm.c@361 PS7, Line 361: break;
break is not useful after a goto or return
Done
https://review.coreboot.org/#/c/33234/7/src/security/intel/stm/SmmStm.c@472 PS7, Line 472: * If 0, list must be terminated by END_OF_RESOURCES.
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/7/src/security/intel/stm/SmmStm.c@472 PS7, Line 472: * If 0, list must be terminated by END_OF_RESOURCES.
Done
Done