Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48286/15/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/car/exit_car.S:
https://review.coreboot.org/c/coreboot/+/48286/15/src/soc/intel/common/block... PS15, Line 135: ebx
[Had discussion with Tim, to make the CAR exit code simpler, we planned to add Kconfig fields for re […]
Ack
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/tigerlake/Kc... File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/48286/17/src/soc/intel/tigerlake/Kc... PS17, Line 255: 0xffff
That sounds really weird. SF_QOS_MASK sets bits for only 8*2 ways by default. […]
That's good point Furquan. I checked on one SKU alone. Reset default value I see is 0xffff on that SKU and I can see that total number of ways is 12. Setting CLOS selector value to 00b is sufficient in my opinion.