Attention is currently required from: Kevin Keijzer, Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin.
Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73450 )
Change subject: mb/asrock/b75-pro3-m: Fix S3 resume and hardware monitoring
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Verified this on two b75pro3-m boards, S3 suspend/resume doesn't work with current code. Board goes to sleep, but comes back with normal boot and actually gets stuck, requiring a hard reset. With this change, suspend/resume works properly.
Also, confirmed with this change sensor readings from the nuovoton are available, whereas previous they were not visible for sensor-detect.
TESTED WORKING on B75 Pro3-M
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e504fe4b60da1d7b9830bea5029101bb8cebcb5
Gerrit-Change-Number: 73450
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Keijzer
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kevin Keijzer
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Comment-Date: Sat, 04 Mar 2023 10:35:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment