[coreboot-gerrit] Change in coreboot[master]: coreboot-id: Add coreboot id based on FMAP entries

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40377 )

Change subject: coreboot-id: Add coreboot id based on FMAP entries
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... 
File src/mainboard/siemens/mc_apl1/mc_apl_vboot.fmd:

https://review.coreboot.org/c/coreboot/+/40377/2/src/mainboard/siemens/mc_ap... 
PS2, Line 9: COREBOOT_ID 0x40
           : 			RO_FRID_PAD 0x780
> The reason I chose FMAP is because flashrom (which I think is a commonly used tool) supports FMAP already. So, extending flashrom to support reading ID is not really a lot of change.

Like I said above, I think the flashrom code for doing this is dead (unused) anyway? So I don't think we need to worry about that immediately, and for potential future uses in other tools I'm not sure the "more likely to know FMAP than CBFS" assumption necessarily holds. If we really want something universally usable, I think we should just put a unique magic number in front of it that tools can search for, and then it's fine to put it (uncompressed) into CBFS too.