Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36067 )
Change subject: mainboard/hatch/Kconfig: Add support for boot with Tianocore payload ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36067/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36067/5//COMMIT_MSG@7 PS5, Line 7: mainboard mb
https://review.coreboot.org/c/coreboot/+/36067/5//COMMIT_MSG@7 PS5, Line 7: Tianocore TianoCore is (unfortunately) the official spelling.
https://review.coreboot.org/c/coreboot/+/36067/5//COMMIT_MSG@9 PS5, Line 9: Tianocore Ditto.
https://review.coreboot.org/c/coreboot/+/36067/5/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/36067/5/src/mainboard/google/hatch/... PS5, Line 44: select ENABLE_ACPI_PM_TIMER It does not look like the correct place and implementation to me. The payload is selected in the payload menu, and somehow the necessary changes should be done there (I think). At least you need to check somehow, if TianoCore was chosen as payload. I also do not think this is board specific, and the option should be added somewhere else.