Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45343 )
Change subject: device/dram: Add method for converting MHz to MT/s
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45343/3/src/device/dram/ddr4.c
File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/45343/3/src/device/dram/ddr4.c@69
PS3, Line 69: 1466
Table 170, DDR4-2933: min_tck >= 0.682 ns, max_tck < 0.750 ns --> max_mhz<1466.28 min_mhz>=1333.33. […]
No, just questioning since 1067 will get doubled to 2133, should we not have 2933 include 1467 MHz and not stop at 1466 MHz?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1433f028afb794fe3e397b03f5bd0565494c8130
Gerrit-Change-Number: 45343
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Sep 2020 23:11:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment