Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/25531
Change subject: cpu/x86: Change Kconfig default for MTRR mirroring ......................................................................
cpu/x86: Change Kconfig default for MTRR mirroring
Change the Kconfig default so that systems will set AP var. MTRRs to pre-calculated settings, not necessarily the current settings of the BSP.
Select the Kconfig symbol for Intel platforms that rely on the FSP to program the MTRRs, and intentionally mirror the MTRRs.
BUG=b:77457944 TEST=Run AMD Padmelon and note var. MTRRs in sync in all CUs
Change-Id: I96f50af0589f7f046d3c56962d48e6a01eba5e8e Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/cpu/x86/Kconfig M src/soc/intel/common/block/cpu/Kconfig 2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/25531/1
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig index 679505b..bc50e02 100644 --- a/src/cpu/x86/Kconfig +++ b/src/cpu/x86/Kconfig @@ -139,13 +139,14 @@
config X86_AP_VMTRRS_MIRROR_BSP bool - default y + default n help Certain implementations may enter the common multi-processor initialization with the variable MTRRs already programmed, but others may elect to set them in the function member .pre_mp_init. This option allows the AP setup feature to exactly mirror the - BSP's MTRR settings. + BSP's MTRR settings. The default is to use calculated settings, + allowing temp ranges to be used during POST.
config PLATFORM_USES_FSP1_0 bool diff --git a/src/soc/intel/common/block/cpu/Kconfig b/src/soc/intel/common/block/cpu/Kconfig index 48f3f16..6ec8967 100644 --- a/src/soc/intel/common/block/cpu/Kconfig +++ b/src/soc/intel/common/block/cpu/Kconfig @@ -10,6 +10,7 @@ config SOC_INTEL_COMMON_BLOCK_CPU_MPINIT bool default n + select X86_AP_VMTRRS_MIRROR_BSP help This option selects Intel Common CPU MP Init code. In this common MP Init mechanism, the MP Init is occurring before