EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46929 )
Change subject: mb/google/zork/var/vilboz: Update touch screen power sequence
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46929/2/src/mainboard/google/zork/v...
PS2, Line 111: "
Is this really 100ms? From the attached datasheet, it didn't look like 100ms delay was required afte […]
Goodix FW need 120ms for IC responds after reset assert. Since we have stop pin, it's better separate with reset_delay 20ms and stop delay 100ms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfc2421061e8b3163d7d5108673351bc17df20ec
Gerrit-Change-Number: 46929
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 29 Oct 2020 05:41:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment