mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31325 )
Change subject: lenovo/g505s/Kconfig: Set framebuffer graphics mode to VESA 118h mode ......................................................................
Patch Set 4:
Patch Set 4:
It's not me but HJK who discovered this effect, and he did it with coreboot 4.8 at November 2018. Here is his full message from the archives: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/LRKJP... .
Ok, it seems he didn't mention the exact config
He shared his 4.8 config with me privately; just uploaded it here - https://pastebin.com/eB09ytRS
I'm rather sure that SET_VESA_MODE alone doesn't make a difference.
Indeed, you are right! I just tested a BMP splashscreen (and also found out how to get it working after so many attempts - more information at https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/4L3CW... ) and it worked for both builds, the only difference between which - was a FRAMEBUFFER_SET_VESA_MODE config enabled/disabled.
So, unless someone (probably not me) will test the latest coreboot/dGPU patches with GRUB to check its' console output, this CB:31325 patch above could be abandoned as "not bringing any real world benefit"; marking it as WIP meanwhile...
You cannot sign off for other people.
He entrusted me to work on his patches to get them merged (he already worked a lot to develop them, now it's my turn to do a fair share), and I promised to mention him at my submissions. I think I've seen it at some Linux kernel patches where a team of developers have been working on some patches, and all these developers have been mentioned this way to give them credit - while just one person has been sending them; so I thought it's a correct way to do it.