Patch Set 4:

It's not me but HJK who discovered this effect, and he did it with coreboot 4.8 at November 2018. Here is his full message from the archives: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/LRKJPXK4D3YEX54GIQBZW5FTDJ3QOGBG/ .

Ok, it seems he didn't mention the exact config

He shared his 4.8 config with me privately; just uploaded it here - https://pastebin.com/eB09ytRS


> I'm rather sure that SET_VESA_MODE alone doesn't make a difference.

Indeed, you are right! I just tested a BMP splashscreen (and also found out how to get it working after so many attempts - more information at https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/4L3CWZV4NW3QXXFNK6AZCFOCWLXH3Q5J/ ) and it worked for both builds, the only difference between which - was a FRAMEBUFFER_SET_VESA_MODE config enabled/disabled.

So, unless someone (probably not me) will test the latest coreboot/dGPU patches with GRUB to check its' console output, this CB:31325 patch above could be abandoned as "not bringing any real world benefit"; marking it as WIP meanwhile...


> You cannot sign off for other people.

He entrusted me to work on his patches to get them merged (he already worked a lot to develop them, now it's my turn to do a fair share), and I promised to mention him at my submissions. I think I've seen it at some Linux kernel patches where a team of developers have been working on some patches, and all these developers have been mentioned this way to give them credit - while just one person has been sending them; so I thought it's a correct way to do it.

View Change

To view, visit change 31325. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b4eacf61d905f1160531a988e192c3b626dca68
Gerrit-Change-Number: 31325
Gerrit-PatchSet: 4
Gerrit-Owner: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 02 Mar 2019 18:40:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment