build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30740 )
Change subject: intel/945 boards: Use smp_write_pci_intsrc() ......................................................................
Patch Set 2:
(62 comments)
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... File src/mainboard/apple/macbook21/mptable.c:
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 45: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x01, 0x00, 0x02, 0x10); /* PCIe root 0.01.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 46: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x02, 0x00, 0x02, 0x10); /* VGA 0.02.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 47: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1b, 0x00, 0x02, 0x16); /* HD Audio 0:1b.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 48: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x00, 0x02, 0x11); /* PCIe 0:1c.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 49: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x01, 0x02, 0x10); /* PCIe 0:1c.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 50: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x02, 0x02, 0x12); /* PCIe 0:1c.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 51: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x03, 0x02, 0x13); /* PCIe 0:1c.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 52: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x00, 0x02, 0x15); /* USB 0:1d.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 53: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x01, 0x02, 0x13); /* USB 0:1d.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 54: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x02, 0x02, 0x12); /* USB 0:1d.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 55: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x03, 0x02, 0x10); /* USB 0:1d.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 56: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x00, 0x02, 0x12); /* LPC 0:1f.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 57: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x01, 0x02, 0x13); /* IDE 0:1f.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 58: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x03, 0x02, 0x10); /* SATA 0:1f.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/apple/macbook21/mptabl... PS2, Line 59: smp_write_pci_intsrc(mc, mp_INT, 0x03, 0x03, 0x00, 0x02, 0x13); /* Firewire 3:03.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c File src/mainboard/lenovo/t60/mptable.c:
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@4... PS2, Line 45: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x01, 0x00, 0x02, 0x10); /* PCIe root 0.01.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@4... PS2, Line 46: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x02, 0x00, 0x02, 0x10); /* VGA 0.02.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@4... PS2, Line 47: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1b, 0x00, 0x02, 0x11); /* HD Audio 0:1b.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@4... PS2, Line 48: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x00, 0x02, 0x14); /* PCIe 0:1c.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@4... PS2, Line 49: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x01, 0x02, 0x15); /* PCIe 0:1c.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 50: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x02, 0x02, 0x16); /* PCIe 0:1c.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 51: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x03, 0x02, 0x17); /* PCIe 0:1c.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 52: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x00, 0x02, 0x10); /* USB 0:1d.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 53: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x01, 0x02, 0x11); /* USB 0:1d.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 54: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x02, 0x02, 0x12); /* USB 0:1d.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 55: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x03, 0x02, 0x13); /* USB 0:1d.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 56: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x00, 0x02, 0x17); /* LPC 0:1f.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 57: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x01, 0x02, 0x10); /* IDE 0:1f.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 58: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x02, 0x02, 0x10); /* SATA 0:1f.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/t60/mptable.c@5... PS2, Line 59: smp_write_pci_intsrc(mc, mp_INT, 0x06, 0x00, 0x00, 0x02, 0x10); /* Cardbus 6:00.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c File src/mainboard/lenovo/x60/mptable.c:
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@4... PS2, Line 45: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x01, 0x00, 0x02, 0x10); /* PCIe root 0.01.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@4... PS2, Line 46: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x02, 0x00, 0x02, 0x10); /* VGA 0.02.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@4... PS2, Line 47: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1b, 0x00, 0x02, 0x11); /* HD Audio 0:1b.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@4... PS2, Line 48: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x00, 0x02, 0x14); /* PCIe 0:1c.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@4... PS2, Line 49: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x01, 0x02, 0x15); /* PCIe 0:1c.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 50: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x02, 0x02, 0x16); /* PCIe 0:1c.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 51: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x03, 0x02, 0x17); /* PCIe 0:1c.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 52: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x00, 0x02, 0x10); /* USB 0:1d.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 53: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x01, 0x02, 0x11); /* USB 0:1d.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 54: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x02, 0x02, 0x12); /* USB 0:1d.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 55: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x03, 0x02, 0x13); /* USB 0:1d.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 56: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x00, 0x02, 0x17); /* LPC 0:1f.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 57: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x01, 0x02, 0x10); /* IDE 0:1f.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 58: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x02, 0x02, 0x10); /* SATA 0:1f.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@5... PS2, Line 59: smp_write_pci_intsrc(mc, mp_INT, 0x05, 0x00, 0x00, 0x02, 0x10); /* Cardbus 5:00.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@6... PS2, Line 60: smp_write_pci_intsrc(mc, mp_INT, 0x05, 0x00, 0x01, 0x02, 0x11); /* Firewire 5:00.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/x60/mptable.c@6... PS2, Line 61: smp_write_pci_intsrc(mc, mp_INT, 0x05, 0x00, 0x02, 0x02, 0x12); /* SDHC 5:00.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c File src/mainboard/lenovo/z61t/mptable.c:
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 45: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x01, 0x00, 0x02, 0x10); /* PCIe root 0.01.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 46: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x02, 0x00, 0x02, 0x10); /* VGA 0.02.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 47: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1b, 0x00, 0x02, 0x11); /* HD Audio 0:1b.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 48: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x00, 0x02, 0x14); /* PCIe 0:1c.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 49: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x01, 0x02, 0x15); /* PCIe 0:1c.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 50: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x02, 0x02, 0x16); /* PCIe 0:1c.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 51: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1c, 0x03, 0x02, 0x17); /* PCIe 0:1c.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 52: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x00, 0x02, 0x10); /* USB 0:1d.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 53: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x01, 0x02, 0x11); /* USB 0:1d.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 54: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x02, 0x02, 0x12); /* USB 0:1d.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 55: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1d, 0x03, 0x02, 0x13); /* USB 0:1d.3 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 56: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x00, 0x02, 0x17); /* LPC 0:1f.0 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 57: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x01, 0x02, 0x10); /* IDE 0:1f.1 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 58: smp_write_pci_intsrc(mc, mp_INT, 0x00, 0x1f, 0x02, 0x02, 0x10); /* SATA 0:1f.2 */ line over 80 characters
https://review.coreboot.org/#/c/30740/2/src/mainboard/lenovo/z61t/mptable.c@... PS2, Line 59: smp_write_pci_intsrc(mc, mp_INT, 0x06, 0x00, 0x00, 0x02, 0x10); /* Cardbus 6:00.0 */ line over 80 characters