Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41030 )
Change subject: soc/intel/gpio: set default value for RXEVCFG in native mode ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41030/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/41030/1/src/soc/intel/common/block/... PS1, Line 202: #define PAD_CFG_NF_BUF_TRIG(pad, pull, rst, func, bufdis, trig) \
bufdis, trig are not applicable to native function, too. […]
""" I have been working an a lenovo board port, where dumped some GPIO values that actually match the macro PAD_CFG_NF_BUF_TRIG(..., NONE, DEEP, NF1, TX_RX_DISABLE, OFF).
I was talking to Angel Pons and Nico Huber on IRC since the datasheets tell nothing about the direction setting in case of native functions. We finally found a comment in 3rdparty/fsp/KabylakeFspBinPkg/Include/GpioConfig.h, stating that multiple parameters do not apply to native function pads.
Do you have any contradictory information on that? If not, we should drop that macro again and when converting from DW values to macros simply set leave non- applicable ones 0.
What do you think? You can talk to me on IRC (c0d3z3r0) or just reply by mail. Looking forward to hear from you! """