Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40375 )
Change subject: util/cbfstool: Allow use of non-ASCII longopt
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
Maybe easier to just pick some random character that we're unlikely to ever need elsewhere (e.g. -Q) for --ibb?
This --ibb option was already added before. Just that the original CL never handled this case. Also, it seemed to help with adding more non-ASCII options. If we want to stick to ASCII options only, probably that can be done separately.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27a4f9af9850e4c892573202904fa9e5fbb64df6
Gerrit-Change-Number: 40375
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Apr 2020 19:38:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment