Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38781 )
Change subject: mb/lenovo: Remove thermal.h header ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38781/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38781/1//COMMIT_MSG@10 PS1, Line 10: autoport
Since everyone who used autoport is using tcrt = 100 and tpsv = 90, how about making them the defaul […]
Can't say anything about this. Anyway should be made in a different patchset I believe.
https://review.coreboot.org/c/coreboot/+/38781/1/src/mainboard/lenovo/t430/a... File src/mainboard/lenovo/t430/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/38781/1/src/mainboard/lenovo/t430/a... PS1, Line 28: gnvs->tmax = 105;
Why does nobody else configure this? Shouldn't it be default anyway?
Honestly I've no idea why almost nobody is using it. I believe this also should be done in a separate change.
https://review.coreboot.org/c/coreboot/+/38781/1/src/mainboard/lenovo/t430/t... File src/mainboard/lenovo/t430/thermal.h:
PS1:
I'd keep the comments from this file
Done.