Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37295 )
Change subject: mb/lenovo/t520: Switch to overridetree
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/K...
File src/mainboard/lenovo/t520/Kconfig:
https://review.coreboot.org/c/coreboot/+/37295/7/src/mainboard/lenovo/t520/K...
PS7, Line 56: default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
Isn't this the default already?
Nope, it's default value is an empty string (see src/Kconfig)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6be9cffe97dcd8f733e3bd5a67a408dd817005a
Gerrit-Change-Number: 37295
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Dec 2019 08:53:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment