Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37647 )
Change subject: hatch/create_coreboot_variant: clean up user-visible output ......................................................................
hatch/create_coreboot_variant: clean up user-visible output
* Add more information in the usage message when the cmdline params are incorrect. * Remove messages that tell the user what to do, because the top-level program that invokes this script will handle those commands, and so this script telling the user what to do is noise (and possibly harmful) * Add more information to the commit message that the script prepares for the user. * Bump script version number.
BRANCH=None BUG=b:140261109 TEST=Create the "sushi" variant of the "hatch" baseboard: `util/mainboard/google/hatch/create_coreboot_variant.sh sushi` Inspect the files in src/mainboard/google/hatch/variants/sushi
Change-Id: I04e949aedce61ed7fc7df681b72c3cfef31b5513 Signed-off-by: Paul Fagerburg pfagerburg@chromium.org --- M util/mainboard/google/hatch/create_coreboot_variant.sh 1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/37647/1
diff --git a/util/mainboard/google/hatch/create_coreboot_variant.sh b/util/mainboard/google/hatch/create_coreboot_variant.sh index 184e54c..7b16d74 100755 --- a/util/mainboard/google/hatch/create_coreboot_variant.sh +++ b/util/mainboard/google/hatch/create_coreboot_variant.sh @@ -13,7 +13,7 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details.
-VERSION="1.0.0" +VERSION="1.0.1" SCRIPT=$(basename -- "${0}")
export LC_ALL=C @@ -21,9 +21,8 @@ if [[ "$#" -lt 1 ]]; then echo "Usage: ${SCRIPT} variant_name [b:bug_number]" echo "e.g. ${SCRIPT} kohaku b:140261109" - echo "Adds a new variant of Hatch to Kconfig and Kconfig.name, creates the" - echo "skeleton files for acpi, ec, and gpio, copies the makefile for" - echo "SPD sources, and sets up a basic overridetree" + echo "* Adds a new variant of the baseboard to Kconfig and Kconfig.name" + echo "* Copies the template files for the baseboard to the new variant" exit 1 fi
@@ -78,11 +77,12 @@ # Now commit the files. git commit -sm "${BASE}: Create ${VARIANT} variant
+Create the ${VARIANT} of the ${BASE} baseboard by copying +the baseboard template files to a new directory named for +the variant. + (Auto-Generated by ${SCRIPT} version ${VERSION}).
BUG=${BUG} TEST=util/abuild/abuild -p none -t google/${BASE} -x -a make sure the build includes GOOGLE_${VARIANT_UPPER}" - -echo "Please check all the files (git show), make any changes you want," -echo "and then push to coreboot HEAD:refs/for/master"