Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37993 )
Change subject: mb/**/acpi_tables.c: Drop lid settings on desktops ......................................................................
mb/**/acpi_tables.c: Drop lid settings on desktops
Unlike laptops and some trash cans, desktop boards do not have a lid.
Change-Id: I5f947e411a4c9295a294f55771cd123de6b1e702 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37993 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/asrock/b75pro3-m/acpi_tables.c M src/mainboard/intel/dcp847ske/acpi_tables.c M src/mainboard/sapphire/pureplatinumh61/acpi_tables.c 3 files changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/asrock/b75pro3-m/acpi_tables.c b/src/mainboard/asrock/b75pro3-m/acpi_tables.c index 114f6e1..6727616 100644 --- a/src/mainboard/asrock/b75pro3-m/acpi_tables.c +++ b/src/mainboard/asrock/b75pro3-m/acpi_tables.c @@ -19,9 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) { - // the lid is open by default. - gnvs->lids = 1; - gnvs->tcrt = 100; gnvs->tpsv = 90; } diff --git a/src/mainboard/intel/dcp847ske/acpi_tables.c b/src/mainboard/intel/dcp847ske/acpi_tables.c index 88c7019..0d9c2c5 100644 --- a/src/mainboard/intel/dcp847ske/acpi_tables.c +++ b/src/mainboard/intel/dcp847ske/acpi_tables.c @@ -28,9 +28,6 @@ gnvs->s5u0 = 1; gnvs->s5u1 = 1;
- // No LID: open by default. - gnvs->lids = 1; - gnvs->tcrt = CRITICAL_TEMPERATURE; gnvs->tpsv = PASSIVE_TEMPERATURE; } diff --git a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c index 9c08af1..a275843 100644 --- a/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c +++ b/src/mainboard/sapphire/pureplatinumh61/acpi_tables.c @@ -18,9 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs) { - // the lid is open by default. - gnvs->lids = 1; - gnvs->tcrt = 100; gnvs->tpsv = 90; }