[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common: Introduce API to get the FSP Reset Status

[Paul Menzel (Code Review)]

Attention is currently required from: Subrata Banik, Derek Huang, Kapil Porwal, Andrey Petrov.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74783 )

Change subject: soc/intel/common: Introduce API to get the FSP Reset Status
......................................................................

Patch Set 2:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74783/comment/30809dc4_0381904c 
PS2, Line 14: Ideally FSP API should be able to return the status (both success and
            : error code) upon exiting the FSP API but unfortunately there are some
            : scenarios in ADL/RPL FSP where MultiPhaseSiInit API is unable to return
            : any ERROR status. Hence, this function provides an additional hook to
            : read the FSP reset status by reading the dedicated HOB without relying
            : on the FSP API exit status code.
Is that dependent on the FSP version, that means, will it be fixed in a future version?

Can this FSP bug detected at runtime?

File src/soc/intel/common/fsp_reset.c:

https://review.coreboot.org/c/coreboot/+/74783/comment/5aae56f8_b191e909 
PS2, Line 56: 	size_t size = 0;
You do not seem to use `size`, so there is no need if it’s uninitialized.

File src/soc/intel/common/reset.h:

https://review.coreboot.org/c/coreboot/+/74783/comment/b56eb6d0_f123a590 
PS2, Line 22: th
the