[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/cse: Move me_read_config32() to common code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35225 )

Change subject: soc/intel/common/block/cse: Move me_read_config32() to common code
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35225/2/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/35225/2/src/soc/intel/common/block/... 
PS2, Line 518: index = 1
> There is no benefit/optimization going with static structure. […]

IMHO, you don't need to add this print then if no benefit, leave it on caller if wishes to add debug msg.

uint32_t me_read_config32(int offset)
{
1. /* Do check if PCH_DEV_CSE != NULL */
2. /* Check device is present in Bus like DID != 0xFFFF to avoid returning junk data (notify with debug msg) if HECI been disable and user doesn't realize that part and wishes to read status  */
    pci_read_config32(PCH_DEV_CSE, offset);
}