1 comment:
File src/soc/intel/common/block/cse/cse.c:
Patch Set #2, Line 518: index = 1
There is no benefit/optimization going with static structure. […]
IMHO, you don't need to add this print then if no benefit, leave it on caller if wishes to add debug msg.
uint32_t me_read_config32(int offset)
{
1. /* Do check if PCH_DEV_CSE != NULL */
2. /* Check device is present in Bus like DID != 0xFFFF to avoid returning junk data (notify with debug msg) if HECI been disable and user doesn't realize that part and wishes to read status */
pci_read_config32(PCH_DEV_CSE, offset);
}
To view, visit change 35225. To unsubscribe, or for help writing mail filters, visit settings.