27 Nov
2019
27 Nov
'19
9:28 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37269 )
Change subject: i945/early_init.c: Use BIT(x) macro ......................................................................
Patch Set 1:
I don't really like such changes. Did you check that *all* those bits in the datasheets are single bit configuration options?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78634ea4f51deb82e98939abbed8f07ce98c117b
Gerrit-Change-Number: 37269
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 27 Nov 2019 08:28:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment