Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35539 )
Change subject: acpi_table_header: Replace hard-coded revision via macro and function ......................................................................
Patch Set 2:
(3 comments)
Done
https://review.coreboot.org/c/coreboot/+/35539/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35539/1//COMMIT_MSG@9 PS1, Line 9: hard code
hard-coded
Ack
https://review.coreboot.org/c/coreboot/+/35539/1//COMMIT_MSG@11 PS1, Line 11: Replace with macro defined in arch/acpi.h
Please put it on the line above.
Done
https://review.coreboot.org/c/coreboot/+/35539/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/acpi.c:
https://review.coreboot.org/c/coreboot/+/35539/1/src/southbridge/intel/lynxp... PS1, Line 77: ssdt->revision = get_acpi_table_revision(SSDT);
This change is not mentioned in the commit message.
Done