Attention is currently required from: Cliff Huang, Eran Mitrani, Jingyuan Liang, Paul Menzel.
Kyoung Il Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81331?usp=email )
Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/drivers/intel/touch/chip.h:
https://review.coreboot.org/c/coreboot/+/81331/comment/bc322fd0_ed83257f :
PS2, Line 29: Touch Host Controller Mode
THC's 3 protocol modes.
https://review.coreboot.org/c/coreboot/+/81331/comment/d608069e_2110288a :
PS2, Line 30: Switch between Intel THC protocol and Industry standard HID Over SPI protocol
Switch among IPTS, HID-SPI and HID-I2C.
https://review.coreboot.org/c/coreboot/+/81331/comment/c2049ef8_06a0890b :
PS2, Line 33: ;
Necessary?
THC HID I2C is for future support.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81331?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e
Gerrit-Change-Number: 81331
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jingyuan Liang
jingyliang@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Henry Barnor
hbarnor@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jingyuan Liang
jingyliang@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 09 Apr 2024 01:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment