[coreboot-gerrit] Change in coreboot[master]: cpu/x86/smm: SMM module loader version 2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43684 )

Change subject: cpu/x86/smm: SMM module loader version 2
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> >
> > I tested this on Lenovo X230 (CPU: Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz) and Asrock B85M Pro4 (CPU: Intel(R) Core(TM) i7-4770S CPU @ 3.10GHz): both locked up inside `src/cpu/x86/smm/smi_trigger.c` function `apm_control()`.
> >
> > Log of the Asrock B85M Pro4: https://paste.flashrom.org/view.php?id=3349
>
> Angel, can you please set MAX_CPUS to a 8 or more in Kconfig?  In server mp_init code we error out if MAX_CPUS is less than what's found in the system, but that's not happening here and hence we are getting this error in the log:
> smm_create_map: more CPUs than originally configured for

Weird... I have MAX_CPUS=8 when building for the Asrock B85M Pro4 and the i7-4770S is a quad-core with HyperThreading, so it has 8 threads... Should be enough. I wonder where `cpus in one segment 30` comes from.