Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42154 )
Change subject: sb/intel/lynxpoint: Use PCI bitwise ops ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42154/13/src/southbridge/intel/lynx... File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/42154/13/src/southbridge/intel/lynx... PS13, Line 250: /* FIXME: Are we supposed to update this register with a constant boolean? */
You fixed up the same thing on line 263, so why not treat them the same?
No, the problem on this line is the `1 < 5` thing. Look closely: it's not a left shift 😜
https://review.coreboot.org/c/coreboot/+/42154/13/src/southbridge/intel/lynx... PS13, Line 619: pci_update_config32
pci_write_config32 since the mask is 0?
It won't be reproducible (the binary will change). pci_write_config32() won't perform any read
Replacing `update` with `and` / `or` works because constants sometimes get optimized away. See lines 608 and 609 as an example: I was able to simplify the former, but not the latter.