Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38504 )
Change subject: soc/intel/tigerlake: Enable SATA ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38504/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/38504/2/src/soc/intel/tigerlake/fsp... PS2, Line 134: memcpy(params->SataPortsDevSlp, config->SataPortsDevSlp,
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38504/2/src/soc/intel/tigerlake/fsp... PS2, Line 134: memcpy(params->SataPortsDevSlp, config->SataPortsDevSlp,
code indent should use tabs where possible
Ack