Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44868 )
Change subject: sc7180: report hardware watchdog reset after reboot
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44868/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44868/10//COMMIT_MSG@7
PS10, Line 7: sc7180 :
Please remove space before the colon.
Done
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/inc...
File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/44868/9/src/soc/qualcomm/sc7180/inc...
PS9, Line 134: u32 aoss_cc_apcs_misc;
I'm not sure what this means or is in reference to, so will let Ravi handle this input.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57ece39ff3d49f2bab259cbd92ab039a49323119
Gerrit-Change-Number: 44868
Gerrit-PatchSet: 12
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 14 Sep 2020 17:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: mturney mturney
mturney@codeaurora.org
Gerrit-MessageType: comment