Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41042 )
Change subject: device: Add a disabling PCIe device bus master function ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41042/2/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/41042/2/src/device/pci_device.c@157... PS2, Line 1572: /** : * Disable device bus master. : * : * This function is to disable device bus master. : * : * @param dev Pointer to the device. : */ Please don't write boiler-plate comments.
Sorry for being picky, but IMHO this comment is just a waste of space. It repeats the function name two times and then the declaration of `dev` one time. Why? All this information is (even easier to read, IMHO) in the next line. So I don't see the need for a comment.