Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45106 )
Change subject: mb/system76/lemp9: Don't configure unused SATA / USB ports
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp...
File src/mainboard/system76/lemp9/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45106/2/src/mainboard/system76/lemp...
PS2, Line 98: USB3_PORT_EMPTY
USB3_PORT_EMPTY sets ocpin=OC_SKIP (=0xff). not setting a port here means OC pin 0 is set. […]
resolved by CB:45112
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5587402700d7b137e20538549b8a09a64cb6a9f
Gerrit-Change-Number: 45106
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 13:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment