Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31206 )
Change subject: Kconfig: Add system type entries for common enclosures ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31206/3/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/31206/3/src/arch/x86/acpi.c@1069 PS3, Line 1069: if (IS_ENABLED(CONFIG_SYSTEM_TYPE_DESKTOP)) Afaik this approach will cause the builds for configs that don't specify a type to switch from desktop to mobile. For some configs that don't specify (e.g., eve [and any poppy0]) this is an improvement, but I'm guessing there's other configs where this wouldn't be a desirable change.