Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Julius Werner, Sudheer Amrabadi.
Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot
......................................................................
Patch Set 6:
(2 comments)
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/247bf8c3_5b82adc7
PS4, Line 12: static struct chipinfo chipinfolut[] = {
Not related directly to this patch, but just some general observations about this code: each entry h […]
Changed structure members range uint32_t to uint16_t, in structure initialization instead of macros used designated initializers, here we are keeping chip_id, because we need it for future purpose use.
https://review.coreboot.org/c/coreboot/+/68384/comment/0d4ac63b_5e4c4968
PS4, Line 57: return false;
Done. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca
Gerrit-Change-Number: 68384
Gerrit-PatchSet: 6
Gerrit-Owner: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
quic_tdas@quicinc.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Taniya Das
quic_tdas@quicinc.com
Gerrit-Attention: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-Comment-Date: Wed, 26 Oct 2022 15:53:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment