[coreboot-gerrit] Change in coreboot[master]: amd/cezanne: adding support for the changed AMD FSP API for USB PHY

[Julian Schroeder (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Julian Schroeder has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )

Change subject: amd/cezanne: adding support for the changed AMD FSP API for USB PHY
......................................................................

Patch Set 4:

(3 comments)

Patchset:

PS3:
> Can we make the FspUsb. […]

Would have to change all the related devicetree entries as well. There are a _lot_..

File src/vendorcode/amd/fsp/cezanne/FspUsb.h:

https://review.coreboot.org/c/coreboot/+/54065/comment/b4feb2ba_ddc633a7 
PS3, Line 42: #endif
> I think you can delete everything below this line.

done

File src/vendorcode/amd/fsp/cezanne/FspUsb.h:

https://review.coreboot.org/c/coreboot/+/54065/comment/2421f2b0_4edd1949 
PS1, Line 44: compdstune
> Can you maybe add some breadcrumbs on where to look for these parameters? Right now I have no idea w […]

People who have to adjust the phys will know. According to our USB phy designers it's a non-user serviceable part ;-). You'd need a 10GHz scope (USB3 Gen 2) and test jigs to really tune the phys.